Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve pylint line-too-long messages in randprocs #681

Conversation

nirmal-j-patel
Copy link
Contributor

In a Nutshell

This PR fixes line-too-long pylint warnings messages in probnum.randprocs

Detailed Description

Some docstrings in probnum.randprocs have long lines. Enabled pylint's line-too-long warning and fixed the resulting warnings. This message was not entirely fixed in doc strings of IntegratedOrnsteinUhlenbeckProcess and IntegratedWienerProcess. This is because these doc strings have an example section. If any linebreak is added to break the lines, the resulting documentation has the same linebreaks.

Related Issues

Closes #668

@nirmal-j-patel nirmal-j-patel force-pushed the probnum_pylint_linelength branch from 6b92977 to db2f22a Compare March 26, 2022 23:08
Copy link
Collaborator

@pnkraemer pnkraemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking care of this! I left some small comments in the diff, let's continue the discussion there :)

@pnkraemer pnkraemer self-assigned this Mar 31, 2022
@codecov
Copy link

codecov bot commented Apr 1, 2022

Codecov Report

Merging #681 (d268737) into main (9b78ca1) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #681   +/-   ##
=======================================
  Coverage   89.93%   89.93%           
=======================================
  Files         192      192           
  Lines        7315     7316    +1     
  Branches     1157     1157           
=======================================
+ Hits         6579     6580    +1     
  Misses        491      491           
  Partials      245      245           
Impacted Files Coverage Δ
...probnum/randprocs/markov/continuous/_diffusions.py 92.85% <ø> (ø)
...probnum/randprocs/markov/continuous/_linear_sde.py 93.66% <ø> (ø)
...rc/probnum/randprocs/markov/continuous/_lti_sde.py 88.88% <ø> (ø)
src/probnum/randprocs/markov/continuous/_sde.py 100.00% <ø> (ø)
...bnum/randprocs/markov/discrete/_linear_gaussian.py 100.00% <ø> (ø)
...probnum/randprocs/markov/discrete/_lti_gaussian.py 71.42% <ø> (ø)
...probnum/randprocs/markov/integrator/_integrator.py 89.18% <ø> (ø)
src/probnum/randprocs/markov/integrator/_ioup.py 100.00% <ø> (ø)
src/probnum/randprocs/markov/integrator/_iwp.py 100.00% <ø> (ø)
src/probnum/randprocs/markov/integrator/_matern.py 100.00% <ø> (ø)
... and 3 more

@nirmal-j-patel nirmal-j-patel force-pushed the probnum_pylint_linelength branch from 3e5231f to e9eb170 Compare April 1, 2022 21:05
Some docstrings have long lines. Enabled pylint's line-too-long warning
and fixed the resulting warnings.

Signed-off-by: Nirmal Patel <[email protected]>
@nirmal-j-patel nirmal-j-patel force-pushed the probnum_pylint_linelength branch from e9eb170 to 683ddb4 Compare April 5, 2022 00:10
Copy link
Collaborator

@pnkraemer pnkraemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pnkraemer pnkraemer merged commit f4ea08e into probabilistic-numerics:main Apr 6, 2022
@nirmal-j-patel nirmal-j-patel deleted the probnum_pylint_linelength branch July 3, 2022 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Easy-to-fix pylint messages in probnum.randprocs
3 participants